search

ros-visualization / python_qt_binding

http://wiki.ros.org/python_qt_binding
BSD 3-Clause "New" or "Revised" License
34 stars 54 forks source link

Ros2 port #52

Closed brawner closed 5 years ago

brawner commented 5 years ago

This ports python_qt_binding to work with ros2 crystal. I've also added tests to ensure pyqt or pyside are installed correctly and the package works as intended.

brawner commented 5 years ago

Link to test https://ci.ros2.org/job/ci_linux/5305/

brawner commented 5 years ago

Ok, CI build failed. I have some work to do I guess.

mlautman commented 5 years ago

@brawner Ping me when this is ready to be reviewed

dirk-thomas commented 5 years ago

Also moving the Python package out of the src folder would be good to either apply in the "upstream" ROS 1 branch or not do it on the ROS 2 branch - since it makes porting patches between them more difficult.

brawner commented 5 years ago

@dirk-thomas from your comments on slack, I found how to set the PACKAGE_DIR argument with ament_python_install_package. Moving files back to src

brawner commented 5 years ago

CI build and tests passed https://ci.ros2.org/job/ci_linux/5343/

dirk-thomas commented 5 years ago

I syncronized the crystal-devel branch to contain the latest state of kinetic-devel so this needs to be rebased.