search

ros-visualization / python_qt_binding

http://wiki.ros.org/python_qt_binding
BSD 3-Clause "New" or "Revised" License
34 stars 54 forks source link

Fixing auto lint tests and making one flake8 change #55

Closed brawner closed 5 years ago

brawner commented 5 years ago

This removes the added python style check files in favor of ament_lint_auto. It also fixes one flake8 issue that snuck through.

CI test https://ci.ros2.org/job/ci_linux/5596

19:48:30 ==> /home/rosbuild/ci_scripts/venv/bin/colcon test-result --test-result-base "build" --all
19:48:30 build/python_qt_binding/test_results/python_qt_binding/flake8.xunit.xml: 1 test, 0 errors, 0 failures, 0 skipped
19:48:30 build/python_qt_binding/test_results/python_qt_binding/lint_cmake.xunit.xml: 3 tests, 0 errors, 0 failures, 0 skipped
19:48:30 build/python_qt_binding/test_results/python_qt_binding/pep257.xunit.xml: 4 tests, 0 errors, 0 failures, 0 skipped
19:48:30 build/python_qt_binding/test_results/python_qt_binding/xmllint.xunit.xml: 1 test, 0 errors, 0 failures, 0 skipped
19:48:30 
19:48:30 Summary: 9 tests, 0 errors, 0 failures, 0 skipped
dirk-thomas commented 5 years ago

Why should the imports test be removed again?

brawner commented 5 years ago

@dirk-thomas Gah, it shouldn't have been. I've restored that test.

dirk-thomas commented 5 years ago

Please use squash merge and delete obsolete branches afterwards.