search

ros-visualization / python_qt_binding

http://wiki.ros.org/python_qt_binding
BSD 3-Clause "New" or "Revised" License
34 stars 54 forks source link

Check for Homebrew's PyQt5 install path #57

Closed brawner closed 5 years ago

brawner commented 5 years ago

This modifies the logic in sip_configure to also check for Homebrew's sip file location. Previous ROS2 MacOS instructions said to symlink PyQt5 -> Qt5, but that's not necessary with this PR.

mlautman commented 5 years ago

Can you get this to pass a test so that we can merge it?

brawner commented 5 years ago

@mlautman Here is a test for the default situation. I'll work with Dirk to test the new condition https://ci.ros2.org/job/ci_linux/5794/