Don't add -l prefix if it already exists.

ros-visualization / python_qt_binding

http://wiki.ros.org/python_qt_binding

BSD 3-Clause "New" or "Revised" License

34 stars 54 forks source link

Don't add -l prefix if it already exists. #59

Closed hgaiser closed 5 years ago

hgaiser commented 5 years ago

Similarly as discussed here, a -l shouldn't be prefixed if a library already has a -l prefix. Recently (cmake 3.13) exported its dependency on pthread by adding -lpthread to ${Boost_LIBRARIES}. Using the sip_helper.py on cmake 3.13 gives the following error:

/usr/sbin/ld: cannot find -l-lpthread

hgaiser commented 5 years ago

Apologies for the delay, holidays and everything. I just pushed the requested change.

dirk-thomas commented 5 years ago

Thanks for the patch.