Replace Qt variable in generated Makefile.

ros-visualization / python_qt_binding

http://wiki.ros.org/python_qt_binding

BSD 3-Clause "New" or "Revised" License

34 stars 54 forks source link

Replace Qt variable in generated Makefile. #64

Closed hgaiser closed 5 years ago

hgaiser commented 5 years ago

This PR replaces the $$[QT_INSTALL_LIBS] variable, introduced in Qt 5.12.4.

For more info, check here.

Note: sipconfig will be unsupported in sip5, so maybe someone should spend time on replacing sipconfig with something else that is not deprecated?

dirk-thomas commented 5 years ago

Thanks for the patch.

so maybe someone should spend time on replacing sipconfig with something else that is not deprecated?

Please create a separate ticket for this separate task. Otherwise it is pretty likely it gets lost once this ticket is closed. Even better would be to consider contributing a pull request :wink: