cmake file from new version of shiboken2 does not set `SHIBOKEN_BINARY` any more

ros-visualization / python_qt_binding

http://wiki.ros.org/python_qt_binding

BSD 3-Clause "New" or "Revised" License

34 stars 54 forks source link

Closed ZHOUYue67 closed 4 years ago

ZHOUYue67 commented 5 years ago

At least for shiboken2 v5.13.0, cmake file set target Shiboken2::shiboken2, not variable SHIBOKEN_BINARY any more.

In shiboken_helper.cmake, we should detect and then choose to use ${SHIBOKEN_BINARY} or Shiboken2::shiboken2 correspondingly.

Workaround for users with this issue: change ${SHIBOKEN_BINARY} to Shiboken2::shiboken2 in shiboken_helper.cmake.

dirk-thomas commented 5 years ago

Please consider to contribute a pull request to address this.

no-preserve-root commented 4 years ago

@dirk-thomas Is the MR #77 okay? It should fix the issue and be compatible with older Shiboken versions.