search

ros-visualization / python_qt_binding

http://wiki.ros.org/python_qt_binding
BSD 3-Clause "New" or "Revised" License
34 stars 54 forks source link

If present, use the sipconfig suggested sip program #70

Closed cottsay closed 5 years ago

cottsay commented 5 years ago

The value of SIP_EXECUTABLE is not used in the sip invocation within sip_configure.py. Instead, the sip_bin configuration is loaded from the sipconfig Python module.

Instead of assuming that the sip executable is called sip in the CMake which detects whether the sip binding generator is present, try to find the executable in the same way that sip_configure.py will.

dirk-thomas commented 5 years ago

Thanks for the patch.