Fix #69: use shiboken target over variable

ros-visualization / python_qt_binding

http://wiki.ros.org/python_qt_binding

BSD 3-Clause "New" or "Revised" License

34 stars 54 forks source link

Fix #69: use shiboken target over variable #77

Closed no-preserve-root closed 5 years ago

no-preserve-root commented 5 years ago

Fixes #69 and should be downward compatible.

dirk-thomas commented 5 years ago

Thanks for the patch.

dirk-thomas commented 5 years ago

Cherry-picked to the crystal-devel branch: fa9114875dad2ab2fee6af34d8ab431cdf86c084.

stertingen commented 4 years ago

Although the variable SHIBOKEN_BINARY is now always correctly set, there are a few variables that are used but potentially empty:

SHIBOKEN_LIBRARY (lines 19, 20, 121, prevents output in line 20)
SHIKOBEN_PYTHON_LIBRARIES (line 120)
SHIBOKEN_INCLUDE_DIR (line 96)

no-preserve-root commented 4 years ago

@stertingen you're right. I think that splitting the CMake file for shiboken2 >= 5.12.2 and one for the legacy version is the way to go; essentially, the CMake integration is fundamentally different and branching on the version is substantially easier than trying to emulate the legacy variables.

I might get a version to work over the next days and will submit a pull request then.

dirk-thomas commented 4 years ago

there are a few variables that are used but potentially empty

See #78 for a new ticket about those.