search

ros-visualization / python_qt_binding

http://wiki.ros.org/python_qt_binding
BSD 3-Clause "New" or "Revised" License
34 stars 54 forks source link

PySide2 uses CMake target instead of variable #78

Closed stertingen closed 4 years ago

stertingen commented 4 years ago

On Arch linux (PySide2 version 5.13.2), the variables PYSIDE_LIBRARY and PYSIDE_INCLUDE_DIR are not set, which leads to build failures like https://github.com/ros-visualization/qt_gui_core/issues/142.

Setting PYSIDE_INCLUDE_DIR as CMake argument is a workaround, but not a clean solution.

A proper fix could look like https://github.com/FreeCAD/FreeCAD/commit/3939e4543ef4be6c50581d9bff77e930fb1d9d03.

dirk-thomas commented 4 years ago

Please consider to contribute a pull request to address this in a backwards compatible way.