search

ros-visualization / python_qt_binding

http://wiki.ros.org/python_qt_binding
BSD 3-Clause "New" or "Revised" License
34 stars 54 forks source link

Fix linking with non framework builds of qt (e.g. from conda-forge) #84

Closed anton-matosov closed 4 years ago

anton-matosov commented 4 years ago

Add auto-detection if qt was built with frameworks option on by probing for QtCore.framework existence Add renaming of libraries to link from Qt to Qt5 for darwin if non-framework build is used

anton-matosov commented 4 years ago

👋 @dirk-thomas, This is my first contribution to ROS and I am not sure what is the process for it. I have opened several PRs to several ROS packages, but didn't hear anything back on any of them. What is the regular process for ROS contribution? What is the usual turnaround time for pull requests?

anton-matosov commented 4 years ago

Hello @dirk-thomas, can you take a look at PR, please?

Tobias-Fischer commented 4 years ago

Works perfectly for me!

dirk-thomas commented 4 years ago

Thanks for the patch.

Tobias-Fischer commented 4 years ago

Will this be backported to melodic/noetic?

dirk-thomas commented 4 years ago

Will this be backported to melodic/noetic?

Not automatically. Thanks for bringing it up. Done in 5c2f6d98fda09196dda07248d315411dd45e5f2d.