search

ros-visualization / python_qt_binding

http://wiki.ros.org/python_qt_binding
BSD 3-Clause "New" or "Revised" License
34 stars 54 forks source link

[melodic] pass ROS_BUILD_SHARED_LIBS to use visibility control properly. #89

Closed seanyen closed 4 years ago

seanyen commented 4 years ago

Many ROS packages adopt this visibility control header to make the packages Windows-compatible. And the visibility control is conditionally guarded by ROS_BUILD_SHARED_LIBS which is defined by catkin in CMake file.

However, for sip module, it is running its own Makefile generated by sip, and this important definition (ROS_BUILD_SHARED_LIBS) is not automatically inherited. In such case, when it is building the sip module and ROS visibility control headers are in use there, it doesn't use the expected visibility control code path.

seanyen commented 4 years ago

@dirk-thomas This is ready for review and merge. Thanks!

seanyen commented 4 years ago

@dirk-thomas Friendly ping.

seanyen commented 4 years ago

@dirk-thomas Following up. Any feedback would be appreciated.

dirk-thomas commented 4 years ago

Thanks for the patch.