search

ros-visualization / qt_gui_core

BSD 3-Clause "New" or "Revised" License
37 stars 76 forks source link

Always prefer 'Tango' icon theme #250

Closed cottsay closed 3 years ago

cottsay commented 3 years ago

The legacy behavior was to attempt to detect if an existing theme was already set which supplied some of the needed icons, and if not, use the Tango theme specifically. If that didn't work either, revert the change to the original theme (or lack thereof).

The current behavior changes the theme only if no theme is set, and only if tango_icons_vendor is installed. This breaks down on Ubuntu Focal because the default theme (hicolor) doesn't supply the necessary icons for rqt to function properly. On Fedora, the default theme (Adwaita) appeared to work properly.

This change makes qt_gui always prefer the 'Tango' theme, and always prefer the version supplied by tango_icons_vendor (if available). If 'Tango' is not available, fall back to the system theme (or lack thereof).

Related to #222, #224, and ros-visualization/tango_icons_vendor#8 Fixes ros-visualization/rqt#249

clalancette commented 3 years ago

I tested this out on Linux, and it seems to be working well. I'm going to also test this out on Windows to make sure things still work there.

clalancette commented 3 years ago

I tested this out on Linux, and it seems to be working well. I'm going to also test this out on Windows to make sure things still work there.

Bah. I can't get Windows to work, but it doesn't work before this change anyway. Something must be messed up in my environment.

Can someone else test out Windows here?

cottsay commented 3 years ago

Can someone else test out Windows here?

@ivanpauno and/or @hidmic - can you give this change a try on your Galactic test instances?

ivanpauno commented 3 years ago

@ivanpauno and/or @hidmic - can you give this change a try on your Galactic test instances?

Sure, I have a windows instance running.

ivanpauno commented 3 years ago

Sure, I have a windows instance running.

Tested on Windows, I see the exact same icons before and after the PR :tada:

clalancette commented 3 years ago

CI: