search

ros-visualization / qt_gui_core

BSD 3-Clause "New" or "Revised" License
37 stars 77 forks source link

:man_farmer: DotToQtGenerator class does not create the expected amount of qt items #255

Closed Blast545 closed 3 years ago

Blast545 commented 3 years ago

Bug Report

This is a change in the expected behavior of the DotToQtGenerator that introduced two test regressions in the buildfarms. Failing tests:

qt_dotgraph.qt_dotgraph.test.dot_to_qt_test.DotToQtGeneratorTest.test_recursive 

self.assertEqual(expected_nodes, nodes_sorted)
1: E       AssertionError: Lists differ: ['"/C[140 chars]', '"/Container/logstate"', '"/finished"', '"/start"'] != ['"/C[140 chars]', '"/Container/logstate"', '"/finished"', '"/start"', '"\\n"']

qt_dotgraph.qt_dotgraph.test.dot_to_qt_test.DotToQtGeneratorTest.test_simple_integration

self.assertEqual(3, len(nodes))  # cluster_foo, foo and bar
 AssertionError: 3 != 4

Reference job: https://ci.ros2.org/view/nightly/job/nightly_linux_debug/2097/

I don't know what dependency changed, but I think the problem comes from the dotcode_to_qt_items method that's returning an extra node "\n".

Blast545 commented 3 years ago

This failure appeared 2 consecutive days in the buildfarm:

https://ci.ros2.org/view/nightly/job/nightly_linux_debug/2097/ https://ci.ros2.org/view/nightly/job/nightly_linux_debug/2098/

However, it stopped appearing. I imagine it was a problem with an upstream library, closing this issue.