Export targets instead of old-style CMake variables

ros-visualization / qt_gui_core

BSD 3-Clause "New" or "Revised" License

37 stars 76 forks source link

Closed sloretz closed 2 years ago

sloretz commented 2 years ago

Part of ament/ament_cmake#365

This makes qt_gui_cpp use ament_export_targets() to export modern CMake targets instead of old-style standard CMake variables.

I removed setting -fPICbecause I could not tell why it would be useful here. I wasn't able to figure out why it was added because it's been there since the beginning of this package

sloretz commented 2 years ago

CI (build: --packages-above-and-dependencies qt_gui_cpp test: --packages-above qt_gui_cpp)

sloretz commented 2 years ago

Rerun of CI