search

ros-visualization / qt_gui_core

BSD 3-Clause "New" or "Revised" License
37 stars 77 forks source link

Switch from rcpputils::fs to std::filesystem #288

Closed christophebedard closed 9 months ago

christophebedard commented 9 months ago

Requires https://github.com/ros-visualization/python_qt_binding/pull/135

Part of https://github.com/ros2/rcpputils/issues/164

Relates to https://github.com/ros/pluginlib/pull/254

Since we were only using rcpputils for rcpputils::fs, remove the dependency completely. Note that we need https://github.com/ros-visualization/python_qt_binding/pull/135 to build the bindings with C++17.

christophebedard commented 9 months ago

The Rpr job failure shows how the bindings generator(s) don't recognize std::filesystem without https://github.com/ros-visualization/python_qt_binding/pull/135

clalancette commented 9 months ago

All right, with https://github.com/ros-visualization/python_qt_binding/pull/135 merged, we can now run CI on just this one: