search

ros-visualization / qt_gui_core

BSD 3-Clause "New" or "Revised" License
37 stars 77 forks source link

Cleanup qt_dotgraph and make the tests more robust. #296

Closed clalancette closed 3 weeks ago

clalancette commented 4 weeks ago
  1. Remove all uses of LooseVersion here. The issue it was protecting against is long gone, and LooseVersion is deprecated. Just remove it.
  2. Remove the "simplify" parameter from "add_edge_to_graph". While this is technically an API change, there are no downstream users as far as I can tell and it had no effect.
  3. During the test, make sure to replace carriage return with spaces. This ensures that on Windows, the tests will pass correctly.
clalancette commented 4 weeks ago

Pulls: https://github.com/ros-visualization/qt_gui_core/pull/296 Gist: https://gist.githubusercontent.com/clalancette/3c195f87d98f7f0751cfb024158e020a/raw/93733cefc09256db0395cdd80e49b21162b23c5d/ros2.repos BUILD args: --packages-above-and-dependencies qt_dotgraph TEST args: --packages-above qt_dotgraph ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14793

clalancette commented 3 weeks ago

@Mergifyio backport humble jazzy

mergify[bot] commented 3 weeks ago

backport humble jazzy

✅ Backports have been created

* [#297 Cleanup qt_dotgraph and make the tests more robust. (backport #296)](https://github.com/ros-visualization/qt_gui_core/pull/297) has been created for branch `humble` * [#298 Cleanup qt_dotgraph and make the tests more robust. (backport #296)](https://github.com/ros-visualization/qt_gui_core/pull/298) has been created for branch `jazzy`