search

ros-visualization / qt_gui_core

BSD 3-Clause "New" or "Revised" License
37 stars 77 forks source link

Cleanup qt_dotgraph and make the tests more robust. (backport #296) #297

Open mergify[bot] opened 3 weeks ago

mergify[bot] commented 3 weeks ago
  1. Remove all uses of LooseVersion here. The issue it was protecting against is long gone, and LooseVersion is deprecated. Just remove it.
  2. Remove the "simplify" parameter from "add_edge_to_graph". While this is technically an API change, there are no downstream users as far as I can tell and it had no effect.
  3. During the test, make sure to replace carriage return with spaces. This ensures that on Windows, the tests will pass correctly.
    This is an automatic backport of pull request #296 done by Mergify.
clalancette commented 3 weeks ago

Pulls: https://github.com/ros-visualization/qt_gui_core/pull/297 Gist: https://gist.githubusercontent.com/clalancette/eaeca268c17bc67b0834f53c2b5bedb5/raw/7bab06113751d90e20a5d54df67aec0e953617cc/ros2.repos BUILD args: --packages-above-and-dependencies qt_dotgraph TEST args: --packages-above qt_dotgraph ROS Distro: humble Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14796