search

ros-visualization / rqt

63 stars 72 forks source link

add missing dependencies for rqt_gui: rospkg-modules, python_qt_binding, rospy #227

Closed cottsay closed 4 years ago

cottsay commented 4 years ago

Since the noetic branch is also the development target branch for melodic, we'll need to use a conditional to support both Python versions. Support for conditionals was added in package manifest version 3, so we also need to bump from the version 1 to the version 3 specification.

Here is where rospkg is imported from rqt_gui: https://github.com/ros-visualization/rqt/blob/fd404459cb844f5999c3924f077ff1cb2e5571ef/rqt_gui/src/rqt_gui/main.py#L40

Python 2 rosdep key: python-rospkg-modules Python 3 rosdep key: python3-rospkg-modules

Closes #226

dirk-thomas commented 4 years ago

Please also add exec_depend for rospy and python_qt_binding.

cottsay commented 4 years ago

Please also add exec_depend for rospy and python_qt_binding.

Done in 5fb1111.