search

ros-visualization / rqt_bag

http://wiki.ros.org/rqt_bag
29 stars 53 forks source link

Highlight topic being selected when opening right-click panel #115

Closed ivanpauno closed 2 years ago

ivanpauno commented 2 years ago

Depends on https://github.com/ros-visualization/rqt_bag/pull/114.

This is how it looks, maybe there's a better way to highlight it

image

ivanpauno commented 2 years ago
wjwwood commented 2 years ago

Also the dark green highlight makes the text hard to read so maybe a lighter color to highlight or switch the text to white as well as highlight.

ivanpauno commented 2 years ago

I have integrated these changes in https://github.com/ros-visualization/rqt_bag/pull/116, to avoid creating code conflicts. That PR is still pretty small.

I don't know how hard it would be but if you could instead highlight the while horizontal row you've selected that would be better.

Addressed. I didn't highlight the timeline, because that will probably look weird, but the highlighting is more notorious now.

Also typically selection is a very light blue (or sometimes affected but he system color scheme) highlight.

Addressed.

Also the dark green highlight makes the text hard to read so maybe a lighter color to highlight or switch the text to white as well as highlight.

Addressed.