search

ros-visualization / rqt_bag

http://wiki.ros.org/rqt_bag
28 stars 52 forks source link

Fix toggle thumbnails button #117

Closed ivanpauno closed 1 year ago

ivanpauno commented 2 years ago

Depends on https://github.com/ros-visualization/rqt_bag/pull/116.

Fix of minor bug I found while using rqt_bag.

The condition to check if to activate or deactivate the thumbnails was almost always false, because len(self._rendered_topics) < len(self.topics) will always be true if some of the topics datatypes do not support rendering. Now, it toggles thumbnails based on the previous state of the button.

ivanpauno commented 1 year ago

@mergifyio backport humble

mergify[bot] commented 1 year ago

backport humble

✅ Backports have been created

* [#124 Fix toggle thumbnails button (backport #117)](https://github.com/ros-visualization/rqt_bag/pull/124) has been created for branch `humble`