search

ros-visualization / rqt_bag

http://wiki.ros.org/rqt_bag
31 stars 55 forks source link

ensure data types match what PyQt expects #118

Closed ijnek closed 2 years ago

ijnek commented 2 years ago

Some more fixes for #111

ijnek commented 2 years ago

Pinging this @ivanpauno, would you be able to review please? #111 explains why these changes are necessary.

ivanpauno commented 2 years ago

@ijnek I needed one extra change to make rqt_bag work, could you double check it?

ijnek commented 2 years ago

@ivanpauno LGTM, thanks for testing it out!

ivanpauno commented 2 years ago

I forgot to run CI ... There shouldn't be surprises but just in case:

ros-discourse commented 2 years ago

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/when-will-rqt-bag-be-synced-on-humble/27168/4

ivanpauno commented 2 years ago

@mergifyio backport humble

mergify[bot] commented 2 years ago

backport humble

✅ Backports have been created

* [#125 ensure data types match what PyQt expects (backport #118)](https://github.com/ros-visualization/rqt_bag/pull/125) has been created for branch `humble`