ros-visualization / rqt_bag

http://wiki.ros.org/rqt_bag
31 stars 55 forks source link

ROS2: Use rosbag2_py Python API, remove all explicit SQLite3 logic #121

Closed emersonknapp closed 2 years ago

emersonknapp commented 2 years ago

Description

The current implementation of rqt_bag for ROS 2 does not allow for different storage implementations, it is explicitly implemented as a SQLite3 reader. Til now this was not a large concern, but as MCAP gains usership, this will become more of a concern. The rosbag2_py API is intended to be a generic interface to ROS 2 bag access and manipulation. Anything that rqt_bag needs, that rosbag2_py does not provide, needs to be added as part of completion of this ticket.

Completion Criteria

emersonknapp commented 2 years ago
emersonknapp commented 2 years ago

Progress tracking:

emersonknapp commented 2 years ago

Followup work - not strictly necessary but required for reasonable performance:

emersonknapp commented 2 years ago

Closing as feature-complete, will finish up that followup separately