Closed emersonknapp closed 2 years ago
See my response in https://github.com/ros-visualization/rqt_bag/pull/126#issuecomment-1317863624 . I'm not convinced that this is what we should do.
I've updated the description to my newest proposal - I haven't seen from what you've said why the branch mirroring should exist.
@clalancette Are you OK with this one?
@clalancette Are you OK with this one?
Yeah, that's fine. Let's go ahead.
See comment https://github.com/ros-visualization/rqt_bag/commit/5048c25ffc0baeb5658b6986298ab4c7ecb4808a#r90157284 for more context
ros2
branch, so that it can't be written to at all - this should block further PRs and remove that confusion