search

ros-visualization / rqt_bag

http://wiki.ros.org/rqt_bag
30 stars 55 forks source link

Remove mirror workflow and state branch policy #134

Closed emersonknapp closed 1 year ago

emersonknapp commented 1 year ago

See comment https://github.com/ros-visualization/rqt_bag/commit/5048c25ffc0baeb5658b6986298ab4c7ecb4808a#r90157284 for more context

clalancette commented 1 year ago

See my response in https://github.com/ros-visualization/rqt_bag/pull/126#issuecomment-1317863624 . I'm not convinced that this is what we should do.

emersonknapp commented 1 year ago

I've updated the description to my newest proposal - I haven't seen from what you've said why the branch mirroring should exist.

mjeronimo commented 1 year ago

@clalancette Are you OK with this one?

clalancette commented 1 year ago

@clalancette Are you OK with this one?

Yeah, that's fine. Let's go ahead.