search

ros-visualization / rqt_bag

http://wiki.ros.org/rqt_bag
31 stars 55 forks source link

[ros2] Use default storage id from rosbag2 #139

Closed Yadunund closed 1 year ago

Yadunund commented 1 year ago

This PR replaces references to sqlite3 with rosbag2_py.get_default_storage_id() so that rqt_bag always defaults to the same storage format as rosbag2.

Yadunund commented 1 year ago

Didn't realize rqt_bag isn't using rosbag2_py so these changes aren't meaningful.

emersonknapp commented 1 year ago

I can't remember offhand but I think also if you omit the storage id the backend uses the default

clalancette commented 1 year ago

CI:

clalancette commented 1 year ago

(we'll also want to backport this to Iron)

clalancette commented 1 year ago

@Mergifyio backport iron

mergify[bot] commented 1 year ago

backport iron

✅ Backports have been created

* [#140 [ros2] Use default storage id from rosbag2 (backport #139)](https://github.com/ros-visualization/rqt_bag/pull/140) has been created for branch `iron`