Reacting on errors happening while loading a bag

ros-visualization / rqt_bag

http://wiki.ros.org/rqt_bag

31 stars 55 forks source link

Reacting on errors happening while loading a bag #14

Closed arne48 closed 7 years ago

arne48 commented 7 years ago

The widget uses the functionalities of the Bag class without catching the eventual exceptions that could be raised due to faulty bags. If this happens the exception was raised up to the terminal where the traceback was printed. In the GUI on the other hand no indication was of an error was printed and "Loading" would have stayed in the status bar indefinitely. The added code block outputs the information about the cause of the error to the status bar and the terminal.

dirk-thomas commented 7 years ago

Thank you for the improvement. I made some small changes:

need to explicitly catch subclasses of ROSBagException, therefore no need for a separate function anymore
mention filename in messages
change some warnings to info messages (unrelated to patch)