ros-visualization / rqt_bag

http://wiki.ros.org/rqt_bag
31 stars 55 forks source link

Use cairocffi as the fallback solution for pycairo #43

Closed seanyen closed 5 years ago

seanyen commented 5 years ago

The cairocffi is another implementation which is API compatible with pycairo, it doesn't contain any C\C++ glue code to cairo SDK so it doesn't require C\C++ toolchain to be presented at pip install, and it only requires a binary compatible cairo shared library on the system. This configuration is convenient for some platforms such as, Windows, to prepare dependencies. So I proposed to add cairocffi as a fallback solution in image_helper.py.

seanyen commented 5 years ago

@mlautman Hope I am pining the correct owner. I'd like to get any feedback on this to see how to make this PR move forward. Thanks!

dirk-thomas commented 5 years ago

Thanks for the patch.