search

ros-visualization / rqt_bag

http://wiki.ros.org/rqt_bag
31 stars 55 forks source link

Fix issue: no vertical scroll bar until window is resized #63

Closed mjeronimo closed 4 years ago

mjeronimo commented 4 years ago

Previously, when loading a bag, if the new timeline height was larger than the bag widget window height, the scroll bar would not show up until the window was resized by the user. This fix forces a resize upon opening a bag so that the new timeline height is taken into account and the scrollbar appears if the timeline height is now greater than the bag widget height, as expected.

Fixes #31

Signed-off-by: Michael Jeronimo michael.jeronimo@openrobotics.org

mabelzhang commented 4 years ago

Hmm, I could not reproduce the original issue. Which Ubuntu + ROS combination do I need to be in to reproduce it? In Ubuntu 20.04 + Noetic, on master branch, the vertical scrollbar shows up for me.

mjeronimo commented 4 years ago

@mabelzhang I just duplicated it on Ubuntu 20.04 and Noetic with the master branch of rqt_bag. Did you make sure that the initial window size is too small to show all topics? You can open rqt_bag and resize the vertical height of the window to make sure it will be too small to show all rows for the bag you're opening. Then, open the bag file. Without resizing yet, there should be no vertical scroll bar. Then, once you do resize the scroll bar shows up.