search

ros-visualization / rqt_bag

http://wiki.ros.org/rqt_bag
30 stars 54 forks source link

Make the save and record dialogs work the same way #64

Closed mjeronimo closed 3 years ago

mjeronimo commented 3 years ago

Previously, the code for getting the filename to record a bag, got a prefix string from the user and unconditionally appended a suffix based on the current date/time. And, in contrast, the code for saving simply let the user specify the output filename without further modification.

Now, to make these dialogs more uniform in their behavior, this change prepopulates both dialogs with a filename based on the current date/time. The user is then free to take the name as-is, or modify it. The result is then used as the filename for the bag file, resulting in consistent behavior for Save (export whole bag or region) and Record.

Signed-off-by: Michael Jeronimo michael.jeronimo@openrobotics.org

jacobperron commented 3 years ago

Another option for CI (that I just thought of) is to try ros-tooling/action-ros-ci with GitHub workflows. This could be enabled in parallel with rosdistro pull request CI.

mjeronimo commented 3 years ago

@mabelzhang Yes, I'd like to run the linting tool(s) and submit a separate PR for that. Also add a LICENSE file as Jacob recommended. Probably focus this cleanup on the ros2 branch.

mabelzhang commented 3 years ago

Sounds good!