search

ros-visualization / rqt_bag

http://wiki.ros.org/rqt_bag
31 stars 55 forks source link

Simplify the playback speed display in the status line #65

Closed mjeronimo closed 4 years ago

mjeronimo commented 4 years ago

Previously, symbols (>,>>,<,<<) and numbers (2x, 1/2x, etc.) were used in combination to represent the current playback speed. In addition, the '1x' case showed only '>', resulting in a potentially confusing display, IMO. Instead, the display can simply show the speed factor - 1x, 2x, 1/2x, etc.

Signed-off-by: Michael Jeronimo michael.jeronimo@openrobotics.org

mjeronimo commented 4 years ago

You're probably right that we could leave ROS1 alone and consider it for ROS2. I don't feel strongly about it for ROS1.

However, the point you mention is part of the problem I have with it: The "<" is not rewind; it can't play backwards. What it appears to mean is that it is playing back at less than 1x speed. So, this PR was about eliminating the partial transport metaphor ("<", ">>", etc.) and simply show the playback rate.

mabelzhang commented 4 years ago

Ohh... I see. Yeah that is pretty confusing. I was tricked into thinking there's a way to rewind somewhere. Even in the wiki, it talks about rewind. Then I almost think it's the button graphics that are misleading. Is that the behavior of these buttons on an old cassette player? I've never used those back buttons on our cassette players, but on modern devices, those buttons in a music player really do rewind.

Anyway, I am inclined to say, if we change this behavior in ROS 1, we should do it all the way or not at all - change the button caption so that it doesn't say Rewind, but that also means updating the wiki, which I don't know how involved we want to get there.

Otherwise, currently, the << in the status bar does correspond with the button's appearance to confirm with the user, yes this is really what we mean for this button, just slowing down, not actually playing backwards.

In ROS 2 we should make this less confusing.

mjeronimo commented 4 years ago

@mabelzhang How about I close this PR for ROS1 and we focus on making these items clearer in ROS2?

mabelzhang commented 4 years ago

Sounds good! Thanks!