search

ros-visualization / rqt_bag

http://wiki.ros.org/rqt_bag
31 stars 55 forks source link

Dynamically resize the timeline when recording #66

Closed mjeronimo closed 4 years ago

mjeronimo commented 4 years ago

Previously, when recording, once the timeline window had filled with messages, additional messages were not displayed. Instead, the window appeared static, even while recording continued.

Now, the timeline window incorporates any newly recorded messages, resizing as needed in order to dynamically update the window.

Signed-off-by: Michael Jeronimo michael.jeronimo@openrobotics.org

mjeronimo commented 4 years ago

@dirk-thomas Is there a historical reason that this package doesn't have 'test_pull_requests' enabled on rosdistro? Should this flag be added to the active ROS1 distributions?

dirk-thomas commented 4 years ago

Is there a historical reason that this package doesn't have 'test_pull_requests' enabled on rosdistro?

The packages don't have any tests so why should there be a pull request job?

mjeronimo commented 4 years ago

I was thinking about ensuring that there were no build issues on target platforms other than that used by the developer.

Now that you mention it though, has there been any automated testing of GUI apps so far?