search

ros-visualization / rqt_bag

http://wiki.ros.org/rqt_bag
31 stars 55 forks source link

Fix tuples for bisect calls #67

Closed mjeronimo closed 4 years ago

mjeronimo commented 4 years ago

Python3 doesn't allow comparisons between 'NoneType' and some other types, like float, generating the following error:

TypeError: '<' not supported between instances of 'float' and 'NoneType'

This error was encountered when calling bisect() with tuples that have a second element as 'None' (one occurance is when displaying all thumbnails) where the corresponding element type is int, float, etc. Instead, single element tuples are created, which result in the correct comparison behavior.

Signed-off-by: Michael Jeronimo michael.jeronimo@openrobotics.org

mjeronimo commented 4 years ago

It should be a separate issue. This PR is targeted specifically at the "TypeError: '<' not supported between instances of 'float' and 'NoneType'" errors.

mabelzhang commented 4 years ago

Issue created #74