mjeronimo
commented
3 years ago That's the behavior without the fix. The fix worked fine for me on Ubuntu 20.04 with Noetic. I opened one terminal and sourced /opt/ros/noetic/setup.bash. Another terminal and sourced the same, then built the 'mjeronimo/fix-dups-in-plot-view' branch of rqt_bag using colcon and then sourced its install/local_setup.bash. Next, opened a ROS1 bag file, 2020-10-05-14-41-57.bag. Displayed the plot view for the cmd_vel topic. Closed plot view and opened it again. In the rqt_bag version with Noetic, it displayed the artifacts. In the fix-dups branch, it does not.
Can you share what you did to see if I can reproduce?
Iterating over the widgets in the layout in forward order when attempting to delete all of the widgets in a layout resulted in some widgets not getting deleted properly. Instead, they should be traversed in reverse order so that the index for each widget does not change and all are deleted.
Fixes #5
Signed-off-by: Michael Jeronimo michael.jeronimo@openrobotics.org