Open mabelzhang opened 4 years ago
I've tried the provided bag file with Kinetic, Melodic, and Noetic and the image_helper patch works for all of them. The thumbnail shows correctly as well as the images when using the Image View plugin.
Without this PR, rqt_bag fails on all three distributions with the following messages:
To test, I did the following:
(All console windows source /opt/ros/\<distribution>/setup.bash in the .bashrc)
// Try the distribution's rqt_bag
// Try the latest rqt_bag
The above is true for all of Kinetic, Melodic, and Noetic. Please let me know if you get a different result following these steps.
The error is printed from a call to
rqt_bag_plugins.image_helper.imgmsg_to_pil
, but I don't know if the cause is in this package or somewhere deeper in the actual image conversion, because I see different behavior in Melodic and Noetic while compiling from the same commit hash.Version: commit hash 3beb083ac2988246f5c7ff579dc4bbacff8d339c Platforms: Ubuntu 18.04 + Melodic vs. Ubuntu 20.04 + Noetic
To reproduce: In
rqt_bag
, load a rosbag containing message typesensor_msgs/CompressedImage
. Toggle thumbnail on.In Melodic, image thumbnails are displayed. No messages are printed in the terminal.
In Noetic, no image thumbnails are displayed. These messages are printed in the terminal
That topic is a
sensor_msgs/CompressedImage
.