Closed MichaelGrupp closed 3 years ago
This is very useful. Please merge asap!
I can confirm this doesn't break Melodic :)
@mjeronimo or @mabelzhang, can you please take a look?
Thank you! :-) Could we get a patch-release with this fix please?
I'd suggest releasing after #94 is merged, too...
Yes, I can release ASAP with both #93 and #94. Thanks for the fixes. I tried this on Kinetic as well.
Thx for the fix! :+1:
Would it make sense to also replace _mergesort
here? It is just a few lines below and using the same function would be a bit more consistent. (Actually I think that someone eventually would run into a bug, if the function get_entries_with_bags()
was be called.)
What do you think?
@tkazik Yes, the save functionality is also broken. I created #96 as a patch.
As noted in #90, the previously used function was removed in ros_comm for Noetic.
This makes rqt_bag usable again on ROS Noetic and is compatible with Python 2 distros.