search

ros-visualization / rqt_bag

http://wiki.ros.org/rqt_bag
31 stars 55 forks source link

Fix raw view #94

Closed peci1 closed 3 years ago

peci1 commented 3 years ago

Fixes #92. Partly reverts #68.

I never know with the encode/decode things, but this is what fixed raw view for me.

peci1 commented 3 years ago

@mjeronimo do you remember why you touched raw view in an image_view PR?

peci1 commented 3 years ago

Maybe I should add that this is a fix for Melodic. Not tested on Noetic. Could that be the reason why the encode was added?

mjeronimo commented 3 years ago

@peci1 Yes, please test on Kinetic and Noetic as well, if you would. If I recall the code did need to be slightly different for each.

peci1 commented 3 years ago

So, Noetic doesn't need this PR. I'll test on Kinetic later.

peci1 commented 3 years ago

Kinetic requires this PR.

peci1 commented 3 years ago

I updated this PR with a version that works on Kinetic, Melodic and Noetic.

peci1 commented 3 years ago

Thanks ;)