Closed MichaelGrupp closed 3 years ago
Crap, heapq.merge
has no key argument in Python 2...
Now it should also work on ROS Melodic. Would be great if someone could confirm this.
@MichaelGrupp I was unable to reproduce an issue on Melodic. I tried to create overlapping bag files, load into rqt_bag and then export to a new bag file. Can you please provide the sequence of steps to reproduce and some sample bag files, if possible? Thanks.
The issue doesn't happen on ROS Melodic because the removal of this rosbag.bag._mergesort
function was not released for Melodic, only Noetic. As far as I understand, rqt_bag is published for both Melodic and Noetic from the master branch so we need to ensure that this patch works for both Python 2 and 3, although the bug itself doesn't exist in Melodic.
Ah, OK. Thanks for the info. I'll try the patch on Melodic.
Works fine on Melodic.
Follow up to #93.
A bit more changes were necessary to keep track of the corresponding bag files for each entry.
Tested on Noetic with two overlapping bagfiles.