Added nested subnamespaces and more options to hide or group topics.

EliteMasterEric commented 7 years ago

rqt_graph has had a long-standing problem; in real use cases, graphs quickly become unwieldy and unreadable, with dynamic reconfigure's parameter topics everywhere, and don't even start with images.

This pull request aims to solve these problems with several changes, including:

Added nested subnamespaces. The "Group Namespaces" checkbox has been replaced with a spin box, allowing users to enter the number of levels of grouping they desire.
Grouped topics (such as action topics) now display as 3D boxes.
Added a checkbox allowing the grouping of topics added by tf2 (from ros/geometry2) (i.e. /tf and /tf_static), in a manner similar to action topics.
Added a checkbox allowing the hiding of topics added by tf2 (from ros/geometry2) (i.e. /tf and /tf_static).
Added a checkbox allowing the grouping of topics added by image_transport (from ros-perception/image_common) (i.e. /, /compressed, /theora, and /compressedDepth), in a manner similar to action topics.
Added a checkbox allowing the hiding of topics added by dynamic_reconfigure (from ros/dynamic_reconfigure) (i.e. /parameter_descriptions and /parameter_updates).

These changes, originally implemented in ros-visualization/rqt_graph#9, have been split into six separate commits, with formatting changes removed, for ease of review.

These changes are dependent on pull request ros-visualization/qt_gui_core#87.

Note that the Hide section of the toolbar has been shifted down to a new line, and margins have been changed as the creation of a new line caused spacing problems.

Three files are attached to this pull request; the launch file I used for testing, a before picture, and an after picture, displaying what rqt_graph looks like before and after the changes. Attachments(1).zip

EliteMasterEric commented 7 years ago

@dirk-thomas These changes have gone 22 days since they have been revised and split into separate requests with no response. Overall, they provide significant improvements to the user experience and I would like them to be implemented as soon as possible.

dirk-thomas commented 6 years ago

These changes are dependent on pull request ros-visualization/qt_gui_core#87.

@MasterEric The qt_gui_core PR still has pending comments and this PR can't be merged before the other one has been.

dirk-thomas commented 6 years ago

This repo only has a single master branch used for all currently active ROS distros (Indigo, Kinetic, Lunar). ros-visualization/qt_gui_core#87 on the other hand is targeting the kinetic-devel branch.

I would rather not create separate branches in this repo for this feature but that would require to backport the qt_gui_core PR to Indigo / Qt 4. Is that something you would want to do after the qt_gui_core PR has been merged into kinetic-devel?

EliteMasterEric commented 6 years ago

Hey @dirk-thomas, I was able to get the changes in this PR working on Indigo by using the changes I made a PR for in ros-visualization/qt_gui_core#111. Please test them out and, if you are able to merge those changes, finally merge these major changes to rqt_graph that I am sure everyone will appreciate.

EliteMasterEric commented 6 years ago

@dirk-thomas If the latest pull request ros-visualization/qt_gui_core#117 is approved promptly, do you think the changes to rqt_graph can be approved in time for the long-term supported Melodic release?

dirk-thomas commented 6 years ago

@ros-pull-request-builder retest this please

dirk-thomas commented 6 years ago

With the qt_gui_core backport merged and released into Indigo this is good to go. I will make a new source release after the merge and release the patch version for Melodic.

Thank you for the contribution.

ros-visualization / rqt_graph

Added nested subnamespaces and more options to hide or group topics. #13