search

ros-visualization / rqt_graph

http://wiki.ros.org/rqt_graph
27 stars 27 forks source link

[galactic] Fix quiet filtering for node_topic graphs #70

Closed DLu closed 3 years ago

DLu commented 3 years ago

New version of PR #69 based on galactic-devel

Here's a standard graph with Debug/Quiet=False

Screenshot from 2021-09-28 10-44-57

However, when we turn on Debug/Quiet, we are not correctly filtering the edges. Screenshot from 2021-09-28 10-44-53

This is an effect of the nodes being properly filtered, but the edges not being filtered, so new nodes with the dot node names (t__rosout) are created.

The new logic always filters the edges (instead of just when graph_mode == NODE_NODE_GRAPH. We also always filter the nt_nodes, which is just empty if graph_mode == NODE_NODE_GRAPH.

@hidmic I think you wrote this bit of logic originally in #35

hidmic commented 3 years ago

Alright, going in! Thanks for the fix @DLu.

hidmic commented 3 years ago

@DLu would you mind to sign off your commit before I merge?

DLu commented 3 years ago

Done

DLu commented 3 years ago

@hidmic How do you want to backport? I can open up new PRs if you want

hidmic commented 3 years ago

How do you want to backport? I can open up new PRs if you want

A backport PR for Foxy sounds good. We can run Foxy CI there.