Closed DLu closed 2 years ago
Alright, going in! Thanks for the fix @DLu.
@DLu would you mind to sign off your commit before I merge?
Done
@hidmic How do you want to backport? I can open up new PRs if you want
How do you want to backport? I can open up new PRs if you want
A backport PR for Foxy sounds good. We can run Foxy CI there.
New version of PR #69 based on galactic-devel
Here's a standard graph with Debug/Quiet=False
However, when we turn on Debug/Quiet, we are not correctly filtering the edges.![Screenshot from 2021-09-28 10-44-53](https://user-images.githubusercontent.com/1016143/135110867-cc207dd4-619e-4077-9dc3-069f7cd90d7e.png)
This is an effect of the nodes being properly filtered, but the edges not being filtered, so new nodes with the dot node names (
t__rosout
) are created.The new logic always filters the edges (instead of just when
graph_mode == NODE_NODE_GRAPH
. We also always filter thent_nodes
, which is just empty ifgraph_mode == NODE_NODE_GRAPH
.@hidmic I think you wrote this bit of logic originally in #35