search

ros-visualization / rqt_image_view

http://wiki.ros.org/rqt_image_view
25 stars 59 forks source link

Add interchangeable qos policies #53

Closed mrawding closed 2 years ago

mrawding commented 3 years ago

This PR allows automatic configuration of subscriber QoS policies. This is important because on some networks, compressed image topics may have specific QoS profile. This PR tries to find the QoS available and sets it to default if not. It has been tested on multiple custom qos profiles and has shown to work very well without errors.

jacobperron commented 2 years ago

Thanks for proposing this improvement!

However, I think defaulting to best_effort is a more straight-forward way to match any publishers. I'm more inclined to accept https://github.com/ros-visualization/rqt_image_view/pull/67 as an alternative to this PR, especially once we enable support for overriding QoS.

jacobperron commented 2 years ago

Closing in favor of #67