search

ros-visualization / rqt_image_view

http://wiki.ros.org/rqt_image_view
25 stars 59 forks source link

Use image_transport and cv_bridge targets #62

Closed sloretz closed 2 years ago

sloretz commented 2 years ago

Fixes #61 ~:warning: This needs to be targeted at a ROS Rolling specific branch.~ Done

sloretz commented 2 years ago

Rolling PR job failed because it used ros-rolling-image-transport 3.1.1, but the target is in 3.1.2. The PR has been merged: https://github.com/ros/rosdistro/pull/31776 , so maybe the rolling image hasn't been updated yet?

mabelzhang commented 2 years ago

I approved but maybe the checks should be rerun?

sloretz commented 2 years ago

I approved but maybe the checks should be rerun?

Yeah, I'm not totally sure how to test this. The rolling jobs don't seem to have built the latest versions of it's dependencies yet. I pushed another commit since I think it will have the same issue with cv_bridge when vision_opencv gets a release. I'll try a local build and report back.

sloretz commented 2 years ago

I'll try a local build and report back.

With the latest version of vision_opencv and this PR this package builds successfully. I tested that I can load the plugin in rqt and visualize an image using image_tools cam2image as a test source. I think that's the best I can test this PR, and the results LGTM

nuclearsandwich commented 2 years ago

The rolling jobs don't seem to have built the latest versions of it's dependencies yet. I pushed another commit since I think it will have the same issue with cv_bridge when vision_opencv gets a release. I'll try a local build and report back.

This is a tradeoff we pay since PR jobs run based on the testing repository but the failure of rqt_image_view is blocking the sync to testing from building since ros-desktop can't be built without this package. :upside_down_face: