Install headers to include/${PROJECT_NAME} and export modern CMake targets

ros-visualization / rqt_image_view

http://wiki.ros.org/rqt_image_view

25 stars 59 forks source link

Install headers to include/${PROJECT_NAME} and export modern CMake targets #63

Closed sloretz closed 2 years ago

sloretz commented 2 years ago

Part of ros2/ros2#1150 - this installs headers to a unique include directory to prevent include directory search order issues when overriding packages from a merged workspace.

I don't have a good way to run CI for this package other than the PR job since vision_opencv is blacklisted from ci.ros2.org

sloretz commented 2 years ago

@mabelzhang got time to review this one?

I don't have a good way to test this one ~as the rolling PR job doesn't appear to have run~ Edit: Huh, this comment triggered it , but like #62 I can test it thoroughly locally on linux.

sloretz commented 2 years ago

@ros-pull-request-builder retest this please

sloretz commented 2 years ago

PR job is green, and this package is blocked from ci.ros2.org, so merging :tada: