Using "sensor data" QoS profile with BEST_EFFORT

ros-visualization / rqt_image_view

http://wiki.ros.org/rqt_image_view

25 stars 59 forks source link

Closed karl-schulz closed 2 years ago

karl-schulz commented 2 years ago

Fixing #41

karl-schulz commented 2 years ago

I don't think the build failure is related to this fix...

jacobperron commented 2 years ago

I also don't think CI failing is a result of this PR. I suspect it is related to our transition to Ubuntu Jammy.

wep21 commented 2 years ago

@jacobperron #66 and https://github.com/wodtko/rqt_image_view/pull/1 (#68) fixes the ci failing.

karl-schulz commented 2 years ago

Looks good to me, thanks for the PR! I've suggested one small change that, I think, would make rqt_image_view even more flexible.

Cool, I did not know about these options.

jacobperron commented 2 years ago

I've rebased to get the latest fixes on rolling-devel.

jacobperron commented 2 years ago

I've filed a ticket upstream (https://github.com/ros-visualization/rqt/issues/262) and disabled the feature (f61e7a7) to avoid misleading users that the exposed ROS parameters can actually be set.