ros-visualization / rqt_reconfigure

http://wiki.ros.org/rqt_reconfigure
Other
22 stars 50 forks source link

Display the wrong value after a parameter result was false #109

Open wilcobonestroo opened 2 years ago

wilcobonestroo commented 2 years ago

I have a node that does not allow some parameters to be updated. If you try to update them, the set param is rejected and you get a false parameter result with an error description as described on https://docs.ros.org/en/rolling/Concepts/About-ROS-2-Parameters.html#parameter-callbacks. If I try to update the value using ros2 param set node parameter value, I correctly see the error message. However, In rqt_reconfigure I can change the value in the UI and press enter. I can see that my node has rejected setting the parameter. The UI does not reflect this. It shows that latest value that I typed in, so it looks like everything was fine. If I deselect and select the node again, I see the correct (the original) value again.

Summary: when the UI tries to set a value, it should look at the response from the node, to check whether the set action was accepted or not.