search

ros-visualization / rqt_reconfigure

http://wiki.ros.org/rqt_reconfigure
Other
23 stars 50 forks source link

Replace deprecated `spin_until_future_complete` #111

Open hliberacki opened 2 years ago

hliberacki commented 2 years ago

Replace deprecated spin_until_future_complete with spin_until_complete

Signed-off-by: Hubert Liberacki hliberacki@gmail.com

hliberacki commented 2 years ago

Due to RCLCPP API change https://github.com/ros2/rclcpp/pull/1874.

hliberacki commented 2 years ago

https://github.com/ros2/rclcpp/pull/1874#issuecomment-1086906375 Passing CI with all related PRs linked and build together.

clalancette commented 2 years ago

This is on the dashing branch, this needs to be separated out for the Rolling -> Iron++ only since this is a breaking change for Dashing/Foxy/Galactic/Humble

We're about to create a 'rolling' branch for this repository anyway (early next week), so we'll retarget it then.

christophebedard commented 7 months ago

This PR is not required anymore due to changes in #126.