search

ros-visualization / rqt_reconfigure

http://wiki.ros.org/rqt_reconfigure
Other
23 stars 50 forks source link

Fixed validator locale when float value is not bound in a range. #121

Closed progtologist closed 1 year ago

progtologist commented 1 year ago

This addresses #21 which was only handled inside the if but not the else statement.

Verified and tested only locally on my system in 20.04/Galactic (but see no reason why it wouldn't work in general).

Could be backported to all ROS2 branches that are maintained.

progtologist commented 1 year ago

@quarkytale any updates on this? It is literary three lines of code!

quarkytale commented 1 year ago

Really sorry this slipped from me

clalancette commented 1 year ago

This one also was merged without CI. We should not do that, particularly not right before a release.