search

ros-visualization / rqt_reconfigure

http://wiki.ros.org/rqt_reconfigure
Other
23 stars 50 forks source link

widget selection is using the wrong type #123

Closed christianrauch closed 1 year ago

christianrauch commented 1 year ago

The selection of the matching widget per parameter type in https://github.com/ros-visualization/rqt_reconfigure/blob/1847d22dc2d1a8daaf8c96c62a93aff9f05c3602/src/rqt_reconfigure/param_client_widget.py#L222-L231 is using the type of the default parameter instead of the type from the parameter description. This means that typed parameters without a default value do not get a configuration widget.

As en example, the new array configuration from https://github.com/ros-visualization/rqt_reconfigure/pull/108 will not work with parameters where ros2 param describe returns

  Type: double array
christianrauch commented 1 year ago

Fixed via https://github.com/ros-visualization/rqt_reconfigure/pull/124.