search

ros-visualization / rqt_reconfigure

http://wiki.ros.org/rqt_reconfigure
Other
23 stars 50 forks source link

get parameter type from descriptor #124

Closed christianrauch closed 1 year ago

christianrauch commented 1 year ago

This changes the source for the parameter type form the default value to the descriptor to fix widget selection for parameters without initial default value.

Closes #123 .

christianrauch commented 1 year ago

@quarkytale Can this be merged now?

clalancette commented 1 year ago

This was merged without any CI, and is causing flake8 errors: https://ci.ros2.org/job/ci_linux-aarch64/13048/testReport/junit/rqt_reconfigure.test/test_flake8/test_flake8/ . @quarkytale can you take a look and fix it?

quarkytale commented 1 year ago

Found the issue 

./src/rqt_reconfigure/param_client_widget.py:44:1: I100 Import statements are in the wrong order. 'from rclpy.parameter import Parameter' should be before 'from rqt_reconfigure.param_api import create_param_client'
from rclpy.parameter import Parameter