search

ros-visualization / rqt_reconfigure

http://wiki.ros.org/rqt_reconfigure
Other
23 stars 50 forks source link

reorder imports to fix flake8 warning #129

Closed christianrauch closed 1 year ago

christianrauch commented 1 year ago

Should fix https://github.com/ros-visualization/rqt_reconfigure/pull/124#issuecomment-1504058841 (@clalancette, @quarkytale).

There is no flake8 config in the repo. Running flake8 in the repo without this PR only reports "E501 line too long" errors.

quarkytale commented 1 year ago

Thanks for the quick resolution!

quarkytale commented 1 year ago

CI:

clalancette commented 1 year ago

FYI, you should run the CI with --packages-above-and-dependencies rqt_reconfigure for build args, and --packages-above rqt_reconfigure for the test args.

(side-note: this is a weakness of colcon/our CI infrastructure that we should eventually fix)