search

ros-visualization / rqt_service_caller

http://wiki.ros.org/rqt_service_caller
7 stars 10 forks source link

remove unuseful type check #11

Closed Karsten1987 closed 5 years ago

Karsten1987 commented 5 years ago

The check I've removed in this PR is actually no longer necessary as the same check is performed in the call to get_service_class in line 157. In order to minimize code duplication, I've decided to remove this block. The assert in line 158 should yield the same error check.

I don't know if this needs a branching to dashing as with this PR no RuntimeError is thrown any longer.

Signed-off-by: Karsten Knese karsten@openrobotics.org

Karsten1987 commented 5 years ago

I am not able to merge PRs on this repo.