The check I've removed in this PR is actually no longer necessary as the same check is performed in the call to get_service_class in line 157. In order to minimize code duplication, I've decided to remove this block. The assert in line 158 should yield the same error check.
I don't know if this needs a branching to dashing as with this PR no RuntimeError is thrown any longer.
The check I've removed in this PR is actually no longer necessary as the same check is performed in the call to
get_service_class
in line 157. In order to minimize code duplication, I've decided to remove this block. Theassert
in line 158 should yield the same error check.I don't know if this needs a branching to dashing as with this PR no
RuntimeError
is thrown any longer.Signed-off-by: Karsten Knese karsten@openrobotics.org