search

ros-visualization / rqt_service_caller

http://wiki.ros.org/rqt_service_caller
7 stars 10 forks source link

Changed the build type to ament_python and Fixed package to run with ros2 run #13

Closed ahcorde closed 3 years ago

ahcorde commented 4 years ago

Fixed package to run with ros2 run rqt_service_caller rqt_service_caller. Related to this issue https://github.com/ros-visualization/rqt_console/issues/20

Signed-off-by: ahcorde ahcorde@gmail.com

ahcorde commented 4 years ago

Running CI up-to rqt_service_caller

sloretz commented 3 years ago

One thing I noticed was that the "refresh" button does not have an icon; it's rendered as an empty button (I'm on Windows). I'm not sure if this is a bug introduced by this PR or an already existing bug. I'll try on Linux when I have a moment.

This bug is already present in 1.0.3 https://github.com/ros-visualization/rqt_service_caller/issues/19

hidmic commented 3 years ago

I verified it can be ros2 run on Windows. All icons show up.

Running CI up to rqt_msg, rqt_srv, rqt_service_caller, rqt_top, rqt_shell, rqt_py_console, rqt_publisher, rqt_plot: